MongoClient.connect: url without database defaults to admin db#87
Open
philippevk wants to merge 1 commit into
Open
MongoClient.connect: url without database defaults to admin db#87philippevk wants to merge 1 commit into
philippevk wants to merge 1 commit into
Conversation
angelo-hub
requested changes
Jan 11, 2019
angelo-hub
left a comment
angelo-hub
left a comment
Collaborator
There was a problem hiding this comment.
this seems good to me can you add a unit test for it?
|
Is this closed? |
Collaborator
Nah, I might just update the pull request myself |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current mongo-mock version, specifying a connect url without any database throws an error.
The mongo documentation says it should default to admin db: https://mongodb.github.io/node-mongodb-native/driver-articles/mongoclient.html#basic-parts-of-the-url