prevent the module from throwing uncatchable errors#136
Open
kjarmicki wants to merge 1 commit into
Open
Conversation
shaunburdick
approved these changes
Dec 23, 2020
Author
|
Thanks for the approve @shaunburdick 🙂 |
Author
|
Hey @shaunburdick can we please merge and release this patch? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
There are situations when this module throws errors from inside of
setTimeoutcallback that are impossible to catch from the outside and cause a process exit (unless caught with globaluncaughtExceptionhandler, but I don't want that 😉). This is the case with any uncaught error thrown inside of a callback scheduled withasyncish.This PR fixes that. I've chosen a method that seemed least invasive to the codebase.