[WFLY-21413] created proposal to promote configuring OIDC scope values for request claims#792
Conversation
github-actions
Bot
added
stability-level/default
darranl
left a comment
darranl
left a comment
There was a problem hiding this comment.
Thank you @rsearls , Just some minor changes to adap to the process.
Also could I please suggest you make the PR title a little more readable so anyone parsing the PR queue can quickly see if this is a feature they are interested in.
| issue: https://github.com/wildfly/wildfly-proposals/pull/792 | ||
| feature-team: | ||
| developer: | ||
| - Farah Juma |
There was a problem hiding this comment.
Rebecca I would suggest in this regard we record you as the developer as you are handing the promotion but in the description acknowledge this is promotion of work previously undertaken by Farah and Prarthioa.
| - Diana Krepinska | ||
| outside-perspective: | ||
| promotes: https://issues.redhat.com/browse/WFLY-21413 | ||
| promoted-by: https://github.com/wildfly/wildfly-proposals/pull/792 |
There was a problem hiding this comment.
This pair I think we need to do differently,
I think the promotes field should be a link to the proposal doc this is promoted, in this doc leave promoted-by empty
Then you can go to the original proposal and add a promoted-by link to this doc. Assume this PR will be merged so reference where the file will end up.
| developer: | ||
| - Farah Juma | ||
| - Prarthona Paul | ||
| sme: |
There was a problem hiding this comment.
As this is being promoted to default you will have an internal feature team formed, I would recommend add the tester as SME and the writer as outside perspective. You don't need the additional ones although nothing to prevent a feature pulling in as many as needed especially if it covers multiple specialisations.
github-actions
Bot
added
stability-level/preview
rsearls
changed the title
|
|
||
| == Community Documentation | ||
|
|
||
| Feature documentation has been added to the Wildfly Elytron OIDC Client doc set. |
There was a problem hiding this comment.
Given the mention of preview in wildfly/wildfly@94215c8 (the preview introduction) then I suppose this section here in the Proposal document should identify to remove the note on preview?
github-actions
Bot
added
stability-level/preview
| @@ -3,6 +3,7 @@ categories: | |||
| - elytron | |||
| - security | |||
| stability-level: preview | |||
There was a problem hiding this comment.
@jamezp I think we may have a tooling problem. It looks like some automation marked this issue as preview stability, but it's for default. My guess is the edit to this file is what led to this.
There was a problem hiding this comment.
This is the original proposal which was preview. The new promoted proposal for this feature is WFLY-21413. I was advised to retain the original proposal but add an"promoted-by:" stmt to it pointing to the WFLY-21413 doc. This was done.
In the WFLY-21413 doc the original WFLY-16532 doc was pointed to by stmt "issue:"
There was a problem hiding this comment.
+1 @rsearls What you did was fine. We just have a tooling issue where some automation reacted incorrectly to this change.
It's no big deal; the GH label that's off isn't critical. I'll manually correct it and we'll see if the automation changes it again, now or if you push this branch again. And if it does, it's still not a big deal.
bstansberry
added
stability-level/default
4 participants
https://issues.redhat.com/browse/WFLY-21413 Promote Elytron's "additional scope for auth request" from preview to default stability.