JBEAP-33965 - Internal urls exposed in prospero#1049
Open
pedro-hos wants to merge 1 commit into
Open
Conversation
pedro-hos
force-pushed
the
JBEAP-33965-url-exposed-main
branch
from
July 20, 2026 14:02
824cd30 to
697523c
Compare
pedro-hos
force-pushed
the
JBEAP-33965-url-exposed-main
branch
from
July 20, 2026 17:31
697523c to
5218518
Compare
TomasHofman
reviewed
Jul 21, 2026
TomasHofman
left a comment
TomasHofman
left a comment
Collaborator
There was a problem hiding this comment.
Discussed over slack - I believe this would not resolve the problem, the internal URL must not be part of the sources at all. Should be provided in the infra via custom Maven settings.xml or system property or something like that.
Collaborator
|
Another way could be to ask prod to remove the URL from sources during productization. For instance EAP contains internal maven repo URLs as well in pom.xml, and it is removed during prod I believe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://redhat.atlassian.net/browse/JBEAP-33974