ELY-2807 Allow complete provider url in the oidc config#2483
Open
fRandOmizer wants to merge 2 commits into
Open
ELY-2807 Allow complete provider url in the oidc config#2483fRandOmizer wants to merge 2 commits into
fRandOmizer wants to merge 2 commits into
Conversation
darranl
requested changes
Jul 17, 2026
darranl
left a comment
darranl
left a comment
Contributor
There was a problem hiding this comment.
Hi @fRandOmizer to begin with before we review please do not change another contributors commits, to continue some work started by someone else I would suggest the following sequence:
Create a new topic branch based on the latest 2.x branch.
git merge the changes from the contributor into that topic branch.
Add your changes as a follow up commit.
Author
|
@darranl Hi, I have updated the branch, which now include the original commit from the previous author. Hopefully it is fixed. Will try to not repeat this mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELY-2807 Allow complete provider url in the oidc config
Based on PR 2193