Skip to content

Fix pinned preview drag and drop state - #1120

Merged
wieslawsoltes merged 4 commits into
masterfrom
agent/issue-1053
Aug 18, 2026
Merged

Fix pinned preview drag and drop state#1120
wieslawsoltes merged 4 commits into
masterfrom
agent/issue-1053

Conversation

@wieslawsoltes

Copy link
Copy Markdown
Owner

Summary

  • resolve pinned preview grip drags to the active tool across validation, preview, docking, and floating paths
  • treat drops back onto the same pinned preview as a no-op
  • preserve whole-dock dragging for regular tool docks
  • add headless regressions for outer docking, self-drop, and outside-drop floating

Validation

  • dotnet test tests/Dock.Avalonia.HeadlessTests/Dock.Avalonia.HeadlessTests.csproj -c Release --no-restore (617 passed)
  • dotnet build Dock.slnx -c Release --no-restore

Closes #1053

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 650c466c9c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Dock.Avalonia/Internal/DockControlState.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a9df02419

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Dock.Avalonia/Internal/DockControlState.cs Outdated
@wieslawsoltes
wieslawsoltes merged commit 26dd673 into master Aug 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DockMvvmSample bugs

1 participant