Fix Browser theme MDI chrome and split drops - #1119
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f87eda595
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Dock/samples/BrowserTabTheme/App.axaml.cs
Line 77 in 93f049d
In the desktop lifetime path, this lambda introduces a code-behind event handler solely to manage ViewModel disposal, contrary to the repository's explicit ReactiveUI rule forbidding event handlers in code-behind. Route the shutdown cleanup through a ReactiveUI lifecycle abstraction, behavior, or service instead of subscribing directly in App.axaml.cs.
AGENTS.md reference: AGENTS.md:L67-L70
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Validation
dotnet test tests/Dock.Avalonia.Themes.UnitTests/Dock.Avalonia.Themes.UnitTests.csproj -c Release --no-restore(64 passed)dotnet build samples/BrowserTabTheme/BrowserTabTheme.csproj -c Release --no-restoredotnet build Dock.slnx -c Release --no-restoreCloses #1056