Skip to content

Fix Browser theme MDI chrome and split drops - #1119

Merged
wieslawsoltes merged 3 commits into
masterfrom
agent/issue-1056-browser-theme-improvements
Aug 18, 2026
Merged

Fix Browser theme MDI chrome and split drops#1119
wieslawsoltes merged 3 commits into
masterfrom
agent/issue-1056-browser-theme-improvements

Conversation

@wieslawsoltes

Copy link
Copy Markdown
Owner

Summary

  • restore native main-window chrome when the BrowserTabTheme sample switches to MDI layout mode
  • expose the full document docking selector so side drops create horizontal or vertical document docks
  • document both behaviors and add a Browser theme resource regression test

Validation

  • dotnet test tests/Dock.Avalonia.Themes.UnitTests/Dock.Avalonia.Themes.UnitTests.csproj -c Release --no-restore (64 passed)
  • dotnet build samples/BrowserTabTheme/BrowserTabTheme.csproj -c Release --no-restore
  • dotnet build Dock.slnx -c Release --no-restore

Closes #1056

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1f87eda595

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread samples/BrowserTabTheme/App.axaml.cs Outdated
Comment thread samples/BrowserTabTheme/MainWindow.axaml Outdated
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Jul 14, 2026
@wieslawsoltes
wieslawsoltes merged commit 8c5c35e into master Aug 18, 2026
4 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

desktop.Exit += (_, _) => DisposeMainWindowViewModel();

P1 Badge Move exit cleanup out of code-behind

In the desktop lifetime path, this lambda introduces a code-behind event handler solely to manage ViewModel disposal, contrary to the repository's explicit ReactiveUI rule forbidding event handlers in code-behind. Route the shutdown cleanup through a ReactiveUI lifecycle abstraction, behavior, or service instead of subscribing directly in App.axaml.cs.

AGENTS.md reference: AGENTS.md:L67-L70

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Browser theme improvements

1 participant