ci: one owner for every action ref — no workflow/composite split#39
Merged
Conversation
Renames composite-refs -> action-refs and widens pinact from composites-only to all of .github (workflows + composites). One job now bumps every uses: ref — whuppi/ci (uniform, via sed) and every third-party action (SHA, via pinact reading composites too). Dependabot is left owning only pub deps. No more half-and-half between Dependabot (workflows) and a sweep (composites).
This comment has been minimized.
This comment has been minimized.
slopfairy
approved these changes
Jul 24, 2026
slopfairy
left a comment
There was a problem hiding this comment.
Tip
Approved — clean rename and scope-widen, no security or correctness regressions
🟡 Suggestions — optional, take it or leave it
tool/versions.env:38-41— The comment still says "inside composite action.yml" and "composite-refs sweep". Update it to "workflows AND composites" and "action-refs job" to match the new scope.tool/ci/upgrade.sh:210— Comment still says "(composite-refs sweep in upgrade-check.yml)". Update to "(action-refs job in upgrade-check.yml)".
✅ Checked
- No
pull_request_target; the workflow isworkflow_call, safe from fork attacks $latestin the sweep step validated against^v[0-9]+\.[0-9]+\.[0-9]+$before sed interpolationpinactinstalled at a pinned version fromversions.env— no floating tool risk--exclude '^whuppi/ci/'correctly keeps whuppi/ci refs as version tags while pinning third-party onesGITHUB_TOKENin the pinact step isgithub.token(contents:read); all writes go through the opt-inCI_ACTIONS_TOKENPATset -euo pipefailpresent in both the sweep and pinact stepsfindtargets are local filesystem paths, not interpolated from untrusted inputgit diff --name-onlystaging matches the widened scope (workflows + actions)- Branch name (
chore/action-refs) and label (upgrade-action-refs) are hardcoded, never interpolated - Job permissions at
contents: read— minimal and correct - Release stamping (
release_stamp_treehook) covers.github/workflows/*.yml, so the renamed job stamps correctly internal-refs-are-mainguard in self-check.yml covers.github/workflows/correctly- Changelog and UPDATING.md accurately describe the change and consumer migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evolves v2.3.0's composites-only sweep into a single owner for every action
uses:ref. No split between Dependabot and a sweep.What changes
composite-refs→action-refs..github(workflows + composites),--exclude '^whuppi/ci/'. One job pins every third-party action to SHA, wherever it lives — including the composite refs Dependabot can't read (#6704).Consumer change (separate PR per repo)
Drop the whole
github-actionsecosystem fromdependabot.yml(not justwhuppi/ci*), keepsweepActions: true+CI_ACTIONS_TOKEN.Verified
--update --exclude '^whuppi/ci/'over workflows+composites proven against pdf: bumpsactions/checkoutin workflows ANDactions/cachein composites, leaves whuppi/ci refs as tags.Cut as v2.4.0 on merge.