ci: add central Renovate runner + renovate secrets env#33
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Reusable workflow (workflow_call), same shape as upgrade-check.yml: each consumer calls it on a schedule and it runs against the CALLING repo (github.repository) — no hardcoded repo list. Renovate reads composite action.yml (dependabot-core#6704 blind spot), keeping whuppi/ci refs uniform and bumping third-party actions hidden in composites. secrets.sh gains an 'org' scope so RENOVATE_TOKEN is stored as a whuppi org secret (visible to every repo) — a reusable workflow runs in the consumer's context and can't read a whuppi/ci env secret. GITHUB_TOKEN can't write .github/workflows/, which is why Renovate needs the PAT.
chaudharydeepanshu
force-pushed
the
ci/renovate-runner
branch
from
July 24, 2026 01:46
7449105 to
9e56237
Compare
This comment has been minimized.
This comment has been minimized.
slopfairy
approved these changes
Jul 24, 2026
slopfairy
left a comment
There was a problem hiding this comment.
Tip
Approved — the switch to workflow_call resolves both prior issues cleanly
Since the last review the design pivoted from workflow_dispatch to workflow_call with a boolean dryRun input. The ternary is now correct (true && 'full' || '' → 'full', false && 'full' || '' → ''), and without a checkout step there is no persist-credentials surface. The workflow is tight.
🟡 Suggestions — optional, take it or leave it
deploy/.deploy/secrets.sh:243—upload_envdoes not handle theorgenv case (see inline). If someone runs./secrets.sh upload org, it would create a repo environment literally called "org" and push secrets there instead of to the org level. Either add org support inupload_envor rejectorgincmd_uploadwith a clear message.
✅ Checked
workflow_callwithdryRun: truedefault — safe default, callers opt into live- No checkout step — the Renovate action clones via the PAT; no GITHUB_TOKEN in git config
permissions: {}at top level, job-scopedcontents: write/pull-requests: write/issues: writeare explicit- Action pinned to full SHA (
3064367...) with version comment,renovate-versionpinned to43.279.0 github.repositoryused inRENOVATE_REPOSITORIES— generic, never hardcodedsecrets.shorg handling incmd_setandcmd_rmuses correct--org/--visibility allflagssecrets.json.exampleupdated consistently
Note: the PR body still describes the old workflow_dispatch design — worth updating before merge so it matches what ships.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First cut of the Renovate migration (design:
_playground/PLAN-renovate-migration.md).What
.github/workflows/renovate.yml— self-hosted Renovate, runs from whuppi/ci, scans consumer repos viaRENOVATE_REPOSITORIES. SHA-pinned action + renovate43.279.0. workflow_dispatch only + dry-run default,environment: renovatefor the token. Pointed atwhuppi/pdf_manipulatorfirst.deploy/.deploy/secrets.sh— accepts arenovateenv and auto-creates the GitHub environment (idempotentPUT), soRENOVATE_TOKENis managed the same Bitwarden-backed way asRELEASE_TOKEN.secrets.json.exampledocuments it.Why: dependabot never scans composite
action.yml(#6704); Renovate does. It keeps everywhuppi/ciref uniform (workflow + composite) and bumps third-party actions frozen in composites — we already hitactions/cache@v5.0.5(a major behind, never bumped).Token is already stored on the
renovateenv (Contents + Workflows + PRs + Issues: write, all whuppi repos).After merge: dispatch →
dryRun=full→ read the log (should extract actions/cache from the composites, whuppi/ci refs uniformly, pub, fvmrc, no PRs opened). Then merge pdf#186 (config), flipdryRun=live, enable the schedule, widen the repo list, remove dependabot.No CHANGELOG entry — internal workflow, not a consumed artifact, so no release.