(#2021) Fix Cherbourg-en-Cotentin labels - #68
Conversation
This patch renames "Tourlaville" localadmin and locality to "Cherbourg-en-Cotentin" which is the current name of the place. Signed-off-by: Jules Cléro <jules@smappen.com>
|
Thanks for the PR, @clero. It looks like there are three separate Tourlaville records at different placetypes in WOF:
Should all three of these records be updated? And are the geometries the same for these places? Cherbourg-en-Cotentin would be considered a new place in WOF, so instead of simply updating the names of the existing records, we'd have to mint new records for Cherbourg-en-Cotentin and supersede the Tourlaville records into them. Happy to walk through the update process a bit more in this PR.. |
|
Thanks for the answer @stepps00. This shape matches:
I think those two items should be renamed to Cherbourg-En-Cotentin as it never was the shape of Tourlaville. Another solution would be to create Cherbourg-En-Cotentin localadmin and locality and update Tourlaville entries (including the county) with following shape: https://www.openstreetmap.org/relation/9122 One last thing, the macro county Cherbourg-octeville: https://spelunker.whosonfirst.org/id/404227907/ should also be named Cherbourg-En-Cotentin IMHO (Cherbourg-Octeville is another old french locality, just like Tourlaville). Hope it is clear. Not sure of the process to add new items on WOF, i will let you tell me how i can help ;). |
|
Yes, that's clear - thanks for the detail here. Since Tourlaville had an "end date" when it ceased to exist, these Tourlaville records will be superseded into new Cherbourg-En-Cotentin records in Who's On First. I'll try to port your commits to a new PR and make the changes to follow this workflow, then ping you as a reviewer before the changes are merged. |
great! thanks @stepps00 |
This patch renames "Tourlaville" localadmin and locality to "Cherbourg-en-Cotentin" which is the current name of the place.
Linked issue: whosonfirst-data/whosonfirst-data#2021