Skip to content

(#2021) Fix Cherbourg-en-Cotentin labels - #68

Open
clero wants to merge 1 commit into
whosonfirst-data:masterfrom
clero:fix-cherbourg-labels
Open

(#2021) Fix Cherbourg-en-Cotentin labels#68
clero wants to merge 1 commit into
whosonfirst-data:masterfrom
clero:fix-cherbourg-labels

Conversation

@clero

@clero clero commented Jan 12, 2023

Copy link
Copy Markdown

This patch renames "Tourlaville" localadmin and locality to "Cherbourg-en-Cotentin" which is the current name of the place.

Linked issue: whosonfirst-data/whosonfirst-data#2021

This patch renames "Tourlaville" localadmin and locality to
"Cherbourg-en-Cotentin" which is the current name of the place.

Signed-off-by: Jules Cléro <jules@smappen.com>
@nvkelso
nvkelso requested a review from stepps00 February 16, 2023 23:52
@stepps00

Copy link
Copy Markdown
Contributor

Thanks for the PR, @clero. It looks like there are three separate Tourlaville records at different placetypes in WOF:

Should all three of these records be updated? And are the geometries the same for these places?

Cherbourg-en-Cotentin would be considered a new place in WOF, so instead of simply updating the names of the existing records, we'd have to mint new records for Cherbourg-en-Cotentin and supersede the Tourlaville records into them. Happy to walk through the update process a bit more in this PR..

@clero

clero commented Feb 20, 2023

Copy link
Copy Markdown
Author

Thanks for the answer @stepps00.
To give you some context, Tourlaville has been combined with some other cities to create Cherbourg-en-Cotentin.
Here is the shape of Cherbourg-en-Cotentin defined on OSM: https://www.openstreetmap.org/relation/5812062

This shape matches:

I think those two items should be renamed to Cherbourg-En-Cotentin as it never was the shape of Tourlaville.

Another solution would be to create Cherbourg-En-Cotentin localadmin and locality and update Tourlaville entries (including the county) with following shape: https://www.openstreetmap.org/relation/9122

One last thing, the macro county Cherbourg-octeville: https://spelunker.whosonfirst.org/id/404227907/ should also be named Cherbourg-En-Cotentin IMHO (Cherbourg-Octeville is another old french locality, just like Tourlaville).

Hope it is clear. Not sure of the process to add new items on WOF, i will let you tell me how i can help ;).

@stepps00

Copy link
Copy Markdown
Contributor

Yes, that's clear - thanks for the detail here. Since Tourlaville had an "end date" when it ceased to exist, these Tourlaville records will be superseded into new Cherbourg-En-Cotentin records in Who's On First.

I'll try to port your commits to a new PR and make the changes to follow this workflow, then ping you as a reviewer before the changes are merged.

@clero

clero commented Feb 24, 2023

Copy link
Copy Markdown
Author

Yes, that's clear - thanks for the detail here. Since Tourlaville had an "end date" when it ceased to exist, these Tourlaville records will be superseded into new Cherbourg-En-Cotentin records in Who's On First.

I'll try to port your commits to a new PR and make the changes to follow this workflow, then ping you as a reviewer before the changes are merged.

great! thanks @stepps00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants