fix superseded parent IDs #23
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ | |
| "mz:categories":[], | ||
| "mz:hierarchy_label":1, | ||
| "mz:is_current":1, | ||
| "mz:min_zoom":13, | ||
| "name:ara_x_preferred":[ | ||
| "\u0645\u0637\u0627\u0631 \u062a\u0648\u0631\u0648\u0646\u062a\u0648 \u0628\u064a\u0631\u0633\u0648\u0646 \u0627\u0644\u062f\u0648\u0644\u064a" | ||
| ], | ||
|
|
@@ -163,10 +163,9 @@ | |
| 85895633, | ||
| 102191575, | ||
| 85633041, | ||
| 101735893, | ||
| 890456343, | ||
| 85682057 | ||
| ], | ||
| "wof:breaches":[], | ||
| "wof:concordances":{ | ||
|
|
@@ -181,16 +180,6 @@ | |
| ], | ||
| "wof:geomhash":"131d17c4a99435510ef6e2b02e5cc478", | ||
| "wof:hierarchy":[ | ||
|
Contributor
There was a problem hiding this comment. So, in this case, the record currently has a dual hierarchy, but only one of the hierarchies is valid.. we should remove this entire hierarchy set so this feature only has one hierarchy (the one below, with "locality_id":101735893).
Author
There was a problem hiding this comment. How do I detect an valid/invalid hierarchy?
Author
There was a problem hiding this comment. I added a56eabe which I think is the correct fix. // deduplicate hierarchies
// remove any hierarchies which are duplicates of, or a subset of another hierarchy
const deduplicatedHierarchies = hierarchies.filter((h1, b1) => {
return !hierarchies.some((h2, b2) => (b1 != b2) && _.isMatch(h2, h1))
})[edit] this deduplication algo was improved further and tested in pelias/wof#25 |
||
| { | ||
| "campus_id":102555091, | ||
| "continent_id":102191575, | ||
|
|
@@ -203,7 +192,7 @@ | |
| } | ||
| ], | ||
| "wof:id":102555091, | ||
| "wof:lastmodified":1594246593, | ||
| "wof:name":"Toronto Lester B Pearson International Airport", | ||
| "wof:parent_id":1108905413, | ||
| "wof:placetype":"campus", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
| "edtf:cessation":"uuuu", | ||
| "edtf:inception":"uuuu", | ||
| "geom:area":0.0, | ||
| "geom:area_square_m":0, | ||
|
Author
There was a problem hiding this comment. this is the command I'm using to run
Author
There was a problem hiding this comment. I'm a bit confuddled by this, why was |
||
| "geom:bbox":"-76.95069,44.24832,-76.95069,44.24832", | ||
| "geom:latitude":44.24832, | ||
| "geom:longitude":-76.95069, | ||
|
|
@@ -16,10 +16,10 @@ | |
| "lbl:bbox":"-76.95569,44.24332,-76.94569,44.25332", | ||
| "lbl:latitude":44.24832, | ||
| "lbl:longitude":-76.95069, | ||
| "lbl:max_zoom":18, | ||
| "mz:hierarchy_label":1, | ||
| "mz:is_current":1, | ||
| "mz:min_zoom":15, | ||
| "mz:note":"Quattroshapes Point Gazetteer import 20170519", | ||
| "qs_pg:aaroncc":"CA", | ||
| "qs_pg:gn_country":"CA", | ||
|
|
@@ -40,8 +40,7 @@ | |
| 102191575, | ||
| 85633041, | ||
| 101736227, | ||
| 890457185 | ||
| ], | ||
| "wof:breaches":[], | ||
| "wof:concordances":{ | ||
|
|
@@ -59,18 +58,10 @@ | |
| "locality_id":101736227, | ||
| "neighbourhood_id":1126060877, | ||
| "region_id":85682057 | ||
| } | ||
| ], | ||
| "wof:id":1126060877, | ||
| "wof:lastmodified":1594246595, | ||
| "wof:name":"Napanee Downtown", | ||
| "wof:parent_id":-1, | ||
| "wof:placetype":"neighbourhood", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our zoom values should remain floats (
13.0, rather than13).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs were run through 'exportify' so I don't have any control over how they are serialised 🤷