Add synchronous VisorClient (step 11)#8
Merged
Conversation
Implements VisorClient backed by SyncVisorTransport with full parity to AsyncVisorClient: all 8 methods, context manager, and export from package root. Adds 32 focused sync client tests covering all methods, error dispatch, and transport close behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VisorClientinsrc/visor/_client.py, backed by the existingSyncVisorTransport— independent of the async client, no wrappingAsyncVisorClientmethods synchronously:filter_listings,get_listing,lookup_vin,filter_facets,search_dealers,get_dealer,dealer_inventory,get_usageVisorClientfrom the package root (visor.__init__) and adds it to__all__Test plan
tests/test_client_sync.py— 32 new tests covering: constructor (explicit key, env var, missing key, env override), auth header propagation, all 8 methods (correct path, param serialization, return type), error dispatch for all status codes (400–500),RateLimitError.retry_after, transport error wrapping asVisorTransportError, context manager closes underlying httpx client, and export assertionpytestsuite passes (224 tests)ruff check src/ tests/cleanmypy src/clean🤖 Generated with Claude Code