Repository navigation
Pull request: Draw timeline connectors only between neighbouring entries - #79
Merged
Merged
Conversation
GitHub runs one continuous line down the timeline, so it trails past the last entry and runs alongside boxes it does not connect. This is our own rule instead: a connector joins two neighbouring entries and nothing else. It never runs past the last entry, alongside a review box, or out of a review group. On pull request pages the single full-height line is replaced by per-entry halves. On issue pages the last entry's line now stops at its badge. The "closed this pull request" badge is red, matching the state label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
whereareiam
added
the
change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #78 (base is its branch).
Why
A deliberate departure from GitHub. GitHub draws one continuous line down the timeline: it trails below the last entry into empty space and runs past boxes it does not connect. Our theme copied that on pull request pages with a single full-height
.ui.timeline::before, which also ran alongside the indented review boxes.The rule
A connector joins two neighbouring timeline entries, and nothing else.
How
::before) and, only when another entry follows, a lower half (::after). Comment and merge boxes draw 12px stubs in their own top and bottom padding with background gradients, switched by:has()and adjacency.Verification
Checked in the preview on open (with review groups and an approval), draft, merged and closed pull requests, and on open and closed issues.
bun vitest(403 passed),bun checkand Prettier pass. Dark theme CSS is 221,969 bytes against the 225,280 limit. Screenshots are not attached.🤖 Generated with Claude Code