Repository navigation
Pull request: Stop the merge menu jumping, keep the header still between tabs, tidy the reviewer row - #77
Merged
Conversation
…een tabs, tidy the reviewer row - A pressed button is briefly transformed, which made the merge arrow the positioning parent of its own menu: the menu opened under the arrow and jumped left when the press transition ended. Buttons that hold a dropdown no longer transform. - The title header had 4px extra padding and a different gap on Commits and Files changed than on Conversation, so switching tabs moved the page. All tabs now share one header box. - A reviewer's row in the sidebar shows the name in bold with 16px muted action icons instead of mixed sizes in the text colour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #76 (base is its branch).
What was wrong
.ui.button:activeappliestransform: translateY(0.5px)with an 80ms transition. A transformed element is the containing block of its absolutely positioned children, so right after the click the arrow button anchored its own menu (menu under the arrow, on the right); when the transition ended the menu fell back to the button group (left).What changed
translateY(0.5px)Verification
Measured in the preview: header, title, edit button and tabs are at identical positions on all three tabs. The menu position was logged through a real click (stable at the group's left edge); the flicker itself is a transient I could not capture, so the fix is from the cause, not from an observed before/after.
bun vitest(403 passed),bun checkand Prettier pass. Screenshots are not attached.🤖 Generated with Claude Code