Skip to content

Pull request: Match GitHub's state colours for closed, draft, merged and blocked pull requests #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whereareiam merged 1 commit into from
Oct 4, 2026
Merged

Pull request: Match GitHub's state colours for closed, draft, merged and blocked pull requests #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions styles/components/issues/pull_files_review.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,25 @@ export default css`
font-weight: 500;
line-height: 18px;
}
/* GitHub's review button is a small 28px control. */
#review-box .ui.ui.ui.button.js-btn-review {
height: 28px;
min-height: 28px;
}
/* "Viewed" is a small bordered button on GitHub. */
.diff-file-header .viewed-file-form {
display: inline-flex;
align-items: center;
gap: 4px;
height: 28px;
padding: 0 8px;
border: 1px solid ${themeVars.color.light.border};
border-radius: ${otherThemeVars.border.radius};
background: ${themeVars.color.button};
color: ${themeVars.color.text.self};
font-size: 12px;
font-weight: 500;
}
.review-box-panel {
display: block;
& > .ui.segment {
Expand Down
22 changes: 19 additions & 3 deletions styles/components/issues/pull_review.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,19 @@ export default css`
align-items: center;
gap: 4px;
font-size: 14px;
font-weight: 600;
}
/* A closed pull request is red on GitHub (purple is for merged, and for closed issues). */
& .issue-title-meta .ui.label.issue-state-label.red {
background-color: ${themeVars.github.bgColor.danger.emphasis} !important;
border-color: ${themeVars.github.bgColor.danger.emphasis} !important;
box-shadow: none;
}
/* A draft is a solid grey label. */
& .issue-title-meta .ui.label.issue-state-label.grey {
color: ${themeVars.github.fgColor.onEmphasis} !important;
background-color: ${themeVars.github.bgColor.neutral.emphasis} !important;
border-color: ${themeVars.github.bgColor.neutral.emphasis} !important;
}
& .pull-desc {
font-size: 14px;
Expand Down Expand Up @@ -220,9 +233,12 @@ export default css`
&.merge-ready > .content {
border-color: ${themeVars.github.bgColor.success.emphasis};
}
/* A blocked pull request: the box border follows the red status badge. */
&:has(> .timeline-avatar.red) > .content {
border-color: ${themeVars.github.bgColor.danger.emphasis};
/* GitHub keeps the badge and border neutral for blocked, conflicting, draft and closed pull requests. */
& > .timeline-avatar:is(.red, .grey, .yellow) {
background: ${themeVars.github.bgColor.neutral.emphasis} !important;
}
&:has(> .timeline-avatar.purple) > .content {
border-color: ${themeVars.github.bgColor.done.emphasis};
}
/* While the merge form is open GitHub shows the form alone, in a neutral box. */
& > .content:has(.pull-merge-actions form .field) {
Expand Down
Loading