Repository navigation
Pull requests: Match GitHub's list layout - #70
Merged
Merged
Conversation
whereareiam
force-pushed
the
feat/pull-request-list-layout
branch
2 times, most recently
from
October 3, 2026 15:34
b780bf5 to
e551d8e
Compare
The pull request list still followed GitHub's earlier layout: a Filters menu joined to the search field in one row with the New button, and open and closed counts shown with icons. It now uses the same layout as the issue list: a sidebar, a heading with the New button, a full-width search field, and Open and Closed with counters. Both lists share their sidebar template and their styles instead of the pull request list keeping its own copies, which also drops rules written for the old search markup. The empty state of both lists follows GitHub's compact block: a 24px muted icon, a 20px heading and one muted line with 32px of padding. It is a compact variant of the shared empty state, not a page rule. The saved filters from the Filters menu and the Labels and Milestones links move into the sidebar, with "Review requested" added for pull requests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
whereareiam
force-pushed
the
feat/pull-request-list-layout
branch
from
October 3, 2026 15:43
e551d8e to
9d17726
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request list still followed GitHub's earlier layout. This gives it the same layout as the issue list.
Changes
theme-empty-compactvariant of the shared empty state, which is GitHub's compact block: a 24px muted icon, a 20px/32.5px heading and one muted 14px line with 32px of padding (about 150px tall, GitHub's is 152px). It was 296px tall with a 24px heading on the pull request list. The pull request heading reads "No pull requests matched your search", as on GitHub; the issue list keeps Forgejo's translated "No results" and gains the icon.pull_list.tsis removed, along with the rules written for the old search markup (about 250 lines).Row content is Forgejo's own and unchanged: the bulk-selection checkboxes, the "#10 opened 2 days ago by sam" wording, the target branch, and the check result after the title.
Comparison
At 1456px in dark mode, in the dev preview (
acme/webapp/pulls).Reference:
github.com/cli/cli/pullsviewed signed out shows the heading row, the full-width search and the counters, but no sidebar; its issue list does have one. The sidebar here follows the issue list and was not checked against a signed-in GitHub view.Before and after screenshots were captured but are not attached: no signed-in browser was available to upload them.
Checks
http://localhost:3000, Forgejo 16.0.3): open and closed lists, each saved filter view, the empty pull request and issue lists onalex/notes, a search with no results, and a 500px viewport with the sidebar collapsed. Apart from its empty state, the issue list is pixel-identical before and after.🤖 Generated with Claude Code