Repository navigation
Controls: Share the counter, switch, empty state and label - #67
Merged
Merged
Conversation
Four small display pieces were written once per page: count pills on profile tabs, release assets, the diff filter and issue state tabs; the Releases/Tags switch on both of its pages; the bordered empty state on profile and release pages; and a hand-built outline label for package types beside Forgejo's native one. They move to components/common as theme-counter, theme-switch and theme-empty, and the package type uses the native ui basic label. The copies had drifted, so the shared versions take GitHub's values: the counter is 20px tall at weight 500 on the muted label background, and the switch is weight 500 on both pages. Organization empty-state overrides that a later profile rule always overrode are removed, along with the unused org-empty rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
whereareiam
added
the
change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #66, which is stacked on #65. Review the last commit only.
Four small display pieces were written once per page and had drifted apart. They move to
components/common, and where the copies disagreed the shared version takes the value measured on github.com.Changes
theme-counter): the count pills on profile and organization tabs, release assets, the diff file filter and the issue state tabs. Page classes keep only layout.theme-switch): the Releases/Tags switch, previously declared twice in the release stylesheet.theme-empty): the bordered box on profile, organization and release pages. Short inline messages inside lists and menus stay as they are.ui basic label, like the repository visibility label, instead of a hand-builtprofile-type-label..org-emptyrules that no template uses, and organization empty-state overrides (240px, no border) that a later profile rule always overrode.CONTRIBUTING.mddocuments each piece, and tests keep count pills, the switch and boxed empty states on the shared classes.Visual changes
Measured before and after in the dev preview at 1440px and 390px across 14 pages; everything not listed is unchanged.
The counter on an inactive issue tab now uses the default text colour instead of inheriting the tab's muted colour. The release empty state is shorter because its icon, heading and text now use the shared 12px gap; its 64px padding is kept.
Checks
bun commitpasses (388 tests on top of Controls: Share button sizing and the select across pages #66).http://localhost:3000, Forgejo 16.0.3): profile, stars, projects, packages, organization overview, repositories, packages and projects, releases (populated and empty), tags, issues, repository home and a commit diff with the file filter active.🤖 Generated with Claude Code