Make relative-URL-with-fragment string account for opaque-path base URLs - #920
Merged
Conversation
a/b against foo:opaque was considered valid by the writing section, but the parser would reject it. Now the writing section makes it clear it won't work. Helps with #704.
annevk
added
the
topic: validation
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Jul 1, 2026
Reject relative URL strings with non-empty pre-fragment content when the base URL has an opaque path. Keep fragment-only strings valid by validating the optional fragment separately before applying the opaque-path base rule. Add coverage for foo:opaque bases, including the a/b case from whatwg/url#920. Co-Authored-By: codex <codex@openai.com>
domenic
approved these changes
Jul 1, 2026
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Jul 1, 2026
Follows whatwg/url#920. Co-authored-by: codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a/b against foo:opaque was considered valid by the writing section, but the parser would reject it. Now the writing section makes it clear it won't work.
Helps with #704.
Preview | Diff