Integrate with MakeRealm#12580
Conversation
Initial attempt at integrating with tc39/ecma262#3728.
| <dd> | ||
| <p>Return <var>execution context</var>.</p> | ||
| </dd> | ||
| <dd><p>Return the <span>JavaScript execution context</span> whose Realm component is |
There was a problem hiding this comment.
Getting the execution context in this way does make MakeRealm nicer, but I find it unfortunate that "realm execution context" is now less defined since there can be javascript execution contexts with the same realm components (and entry realm being defined relative to this). I was wondering here whether this algorithm should take an execution context as an argument (and extract the realm from there). Unfortunately this does go against the layering desired in tc39/ecma262#3728 though by instead doing EC into realm creation
There was a problem hiding this comment.
Probably need input from @jmdyck and @nicolo-ribaudo on this. I don't have strong opinions.
There was a problem hiding this comment.
Unfortunately this does go against the layering desired in tc39/ecma262#3728 though
You can probably downgrade "desired" to "suggested". If HTML would like IHDR to pass the realm execution context (rather than the realm) to the 'customizations' callback, I don't think that's a problem.
There was a problem hiding this comment.
Yeah we're happy to do whatever HTML needs, we just want to make the customizations more explicit.
There was a problem hiding this comment.
Okay, I think @shannonbooth is correct that it would be less awkward if the execution context is passed in because otherwise you'd assume an accessor existing on Realm that gives you the execution context, which I don't think is what we want. I can update this PR (maybe next week) assuming that change is made on the JS side.
4 participants
Initial attempt at integrating with tc39/ecma262#3728.
This should be editorial.
/browsers.html ( diff )
/document-lifecycle.html ( diff )
/document-sequences.html ( diff )
/imagebitmap-and-animations.html ( diff )
/infrastructure.html ( diff )
/nav-history-apis.html ( diff )
/webappapis.html ( diff )
/workers.html ( diff )
/worklets.html ( diff )