Conversation
546d519 to
ad0e6b8
Compare
annevk
left a comment
There was a problem hiding this comment.
This looks good to me. Since it's restricted to same-origin I don't think this really increases the risk of anything bad happening.
The one thing that gives me pause, but was apparently already the case, is that these values persist "forever". But maybe that's more of a comment to be had on bfcache, that expiring after a couple of days is probably a good idea.
|
Fixed nits. @mustaqahmed is working on web platform tests; it's been a bit tricky to test but I think we're getting close to a solution. I'll wait to merge until those are ready. I filed Gecko and MDN bugs, but https://bugs.webkit.org/ is down at the moment so I'll have to do that later. |
|
A colleague brought up some good points:
|
I agree with this.
I'm less sure about this. My instinct was to just do whatever was easiest to spec/implement, which in this case was to allow it to work in iframes. |
I'm no longer sure about this. It seems like most parts of the spec only compare the endpoint origins in A -> B -> A navigations today:
There's also one cases that is confusing:
The only case, in HTML at least, that unambiguously changes behavior for A -> B -> A cases, is unload timing info, which gets censored in those cases. Given this situation, I'd prefer sticky activation is carried over in A -> B -> A cases. Unless we have a compelling security story for a hole that carrying it over creates. Optionally, in the future, someone could investigate whether our choices in all the above-listed cases are coherent, and if we should move to a model that considers A -> B -> A "more cross-origin". (Although I suspect the compat implications might be bad.) |
|
I don't think that's correct? We call "enforce a response's opener policy" for each response we get, which includes redirect responses as navigate doesn't follow those automatically. The risk of exploitation seems minimal, but it's the standard confused deputy attack scenario. A navigates to B which redirects to A2. A2 doesn't think it's in a state where it can hold sticky activation, but it actually does, which results in something unfortunate. |
You're right, although we only do the final BCG swap checking at the end, the "COOP enforcement result" structure is modified each time through the loop in a cumulative way. So that leaves us at 6 endpoint-only checks, 2 all-legs checks, and 1 inconsistent-depending-on-bfcache check. Sticky activation feels more similar to things like navigation API state or |
Intent to Ship: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/68b0b943.050a0220.270bc4.0090.GAE%40google.com Spec PR (already secured another browser's approval): whatwg/html#11454 Fixed: 433729626 Change-Id: Ib475166aeec709837c9d67f6936f51abdc38c6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6961179 Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Auto-Submit: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1523044}
…igation Original change's description: > Enable carrying sticky-activation state across same-origin navigation > > Intent to Ship: > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/68b0b943.050a0220.270bc4.0090.GAE%40google.com > > Spec PR (already secured another browser's approval): > whatwg/html#11454 > > Fixed: 433729626 > Change-Id: Ib475166aeec709837c9d67f6936f51abdc38c6a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6961179 > Commit-Queue: Vladimir Levin <vmpstr@chromium.org> > Auto-Submit: Mustaq Ahmed <mustaq@chromium.org> > Reviewed-by: Vladimir Levin <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1523044} (cherry picked from commit 96f69eb) Bug: 448428855,433729626 Change-Id: Ib475166aeec709837c9d67f6936f51abdc38c6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7004556 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7444@{#80} Cr-Branched-From: 29907d3-refs/heads/main@{#1522585}
|
I'd like to finish this and have read through the discussion. @annevk raised two issues in #11454 (comment). On iframes, it seems simpler to just allow those navigations to carry over sticky activation. The remaining issue is A -> B -> A navigation where B is a redirect back to A. This PR currently does carry forward sticky activation in this case. @annevk what is your preference, to move forward with this as proposed, or ensure that A -> B -> A does not carry forward sticky activation? In either case we should file an issue about the lack of consistency and decide on what we want the default for new things to be. |
|
I would prefer not carrying it forward in those cases and testing that, to prevent potential attacks. If we can somehow find proof those attacks don't exist, maybe an exception can be made. |
|
Thanks @annevk. First step is a test to confirm without a doubt what the behavior implemented in Chromium is. I've asked @mustaqahmed about that. |
|
I've now updated this PR to not carry forward sticky activation through a A -> B -> A navigation. @annevk can you give this another look? |
https://bugs.webkit.org/show_bug.cgi?id=313716 Reviewed by NOBODY (OOPS!). Implement sticky user activation carry-over per whatwg/html#11454, centralized in LocalDOMWindow::carryOverStickyActivationFromPreviousWindow and applied at two entry points: - DocumentWriter::begin carries sticky activation onto a same-origin destination, suppressed when the redirect chain crossed origins (guards A -> B -> A confused-deputy patterns). - FrameLoader::open(CachedFrameBase&) applies the same rule on bfcache reactivation; no network load, so the redirect suppressor is N/A. Builds on the explicit sticky/history-action activation booleans on LocalDOMWindow (bug 316317); carry-over sets m_hasStickyActivation on the destination window when the source had sticky activation and the navigation stayed same-origin. Only sticky activation is carried over, not transient or history-action. Gated behind StickyUserActivationAcrossSameOriginNavigationsEnabled (testable, off by default, auto-enabled in WebKitTestRunner). * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigate-to-crossorigin-redirect-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigate-to-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-sameorigin-expected.txt: * LayoutTests/platform/ios/TestExpectations: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/loader/DocumentWriter.cpp: * Source/WebCore/loader/FrameLoader.cpp: * Source/WebCore/page/LocalDOMWindow.cpp: * Source/WebCore/page/LocalDOMWindow.h:
|
Apart from https://gist.github.com/annevk/8fef6335f0442b9124114bbb54f17b0f there's two other issues worth discussing:
|
|
What would be the process for feature detection here? In the instance of, say, a video player that carries playback through from a thumbnail to fullscreen presentation it would be preferable to still use a same-page transition rather then a multi-page that won't preserve playback state. But I'm not clear how you'd be able to know ahead of time whether it will or not. |
The blockers there were addressed in 2e8536a and an update to the PR description. I also took some of the suggestions in 6329610 and f4a1274, but not all of it. In particular the claimed null deref that would be fixed by moving a step into the "Otherwise" branch, I really can't tell from looking at the algorithm that it might do a null deref, the condition is "If changingNavigableContinuation's update-only is true, or targetEntry's document is displayedDocument" and I don't understand what's implied by that being false.
Fixed in c71dd74.
I have a change prepared by AI for this that looks like this: --- a/source
+++ b/source
@@ -112989,11 +112989,14 @@ <h4>Shared document creation infrastructure</h4>
<li>
<p>If <var>browsingContext</var>'s <span>active document</span>'s <span>is initial
- <code>about:blank</code></span> is true, and <var>browsingContext</var>'s <span>active
+ <code>about:blank</code></span> is true, <var>browsingContext</var>'s <span>active
document</span>'s <span data-x="concept-document-origin">origin</span> is <span>same
origin-domain</span> with <var>navigationParams</var>'s <span
- data-x="navigation-params-origin">origin</span>, then set <var>window</var> to
- <var>browsingContext</var>'s <span>active window</span>.</p>
+ data-x="navigation-params-origin">origin</span>, and <var>navigationParams</var>'s <span
+ data-x="navigation-params-response">response</span>'s <span
+ data-x="concept-response-has-cross-origin-redirects">has cross-origin redirects</span> is
+ false, then set <var>window</var> to <var>browsingContext</var>'s <span>active
+ window</span>.</p>
<p class="note">This means that both the <span data-x="is initial about:blank">initial
<code>about:blank</code></span> <code>Document</code>, and the new <code>Document</code> thatI'm not very confident about this though. It has the appearance of a correct fix, but I don't know this infrastructure. I can create a separate PR for it if you like. |
@alastaircoote I'm afraid it just won't be possible to feature detect this since it doesn't introduce any new API surface area. |
AI reviewReview at 2504bf9. Spec correctness
Security
Chromium divergences (
Tests
On process: annevk approved before the redirect changes and hasn't re-approved, and smaug hasn't approved. The follow-up issue foolip promised about A→B→A consistency doesn't seem to have been filed. |
This is intended to carry sticky activation across a same-origin navigation where the browsing context group changes due to COOP.
|
@zcorpan I have pushed two fixes that I thought would make sense. The remaining three things under "spec correctness" I don't not find actionable. For Chromium differences I will just file a Chromium bug to align with this PR. There are new tests for this, but of course there are tonnes of permutations that could be tested. There is work on this in WebKit, and I think it would make the most sense to identify missing test coverage as part of that. |
|
I've filed https://crbug.com/568041944 and updated OP to reference that. |
|
I have filed #13015 about other A->B->A cases not being consistent. |
More AI review |
https://bugs.webkit.org/show_bug.cgi?id=313716 Reviewed by NOBODY (OOPS!). Implement sticky user activation carry-over per whatwg/html#11454, centralized in LocalDOMWindow::carryOverStickyActivationFromPreviousWindow and applied at two entry points: - DocumentWriter::begin carries sticky activation onto a same-origin destination, suppressed when the redirect chain crossed origins (guards A -> B -> A confused-deputy patterns). - FrameLoader::open(CachedFrameBase&) applies the same rule on bfcache reactivation; no network load, so the redirect suppressor is N/A. Builds on the explicit sticky/history-action activation booleans on LocalDOMWindow (bug 316317); carry-over sets m_hasStickyActivation on the destination window when the source had sticky activation and the navigation stayed same-origin. Only sticky activation is carried over, not transient or history-action. Gated behind StickyUserActivationAcrossSameOriginNavigationsEnabled (testable, off by default, auto-enabled in WebKitTestRunner). * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigate-to-crossorigin-redirect-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigate-to-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-sameorigin-expected.txt: * LayoutTests/platform/ios/TestExpectations: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/loader/DocumentWriter.cpp: * Source/WebCore/loader/FrameLoader.cpp: * Source/WebCore/page/LocalDOMWindow.cpp: * Source/WebCore/page/LocalDOMWindow.h:
This was previoiusly broken, "If navigable's container is not null" refered to variable that was never defined.
The condition looks a bit different in the two branches, but should amount to the same thing, with the information coming from the sourceDocument argument to the navigate algorithm.
See discussion in WICG/view-transitions#239 and #11328 (comment).
This also redefines history-action user activation as a simple boolean, instead of using the timestamp infrastructure.
Details:
/cc @mustaqahmed @nickcoury
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/document-lifecycle.html ( diff )
/interaction.html ( diff )