Add FileSystemHandle.remove method by a-sully · Pull Request #9 · whatwg/fs

a-sully · 2022-03-07T22:03:19Z

Migrated from WICG/file-system-access#283 (see #2)

Adds the ability for a file or directory to delete itself. See the proposal: https://github.com/whatwg/fs/blob/main/proposals/Remove.md

Currently, it is not possible to remove a file or directory given its handle. You must obtain the handle of the parent directory and call FileSystemDirectoryHandle.removeEntry().

This would enable the common use case where you obtain a file handle from showSaveFilePicker(), but then decide you don't want to save after all, and delete the file, or clearing an entire bucket file system.

At least two implementers are interested (and none opposed):
- Chrome
- …
Tests are written and can be reviewed and commented upon at:
- https://github.com/web-platform-tests/wpt/blob/master/file-system-access/script-tests/FileSystemBaseHandle-remove.js
Implementation bugs are filed:
- Chrome: https://crbug.com/1114923
- Firefox: …
- Safari: …

(See WHATWG Working Mode: Changes for more details.)

Preview | Diff

annevk

You'll need to make your membership of the googlers GitHub organization public to appease the IPR bot.

Removes the extra check added in https://crrev.com/c/3123735. See recent discussion on the spec here: whatwg/fs#9 (comment) Bug: 1114923, 1399660 Change-Id: I0afd561238ae44dfa055e6fff234e801ee8de616

Spec PR: whatwg/fs#9 Bug: 1114923 Change-Id: Ie52068e0053cf3a1b693e09c5623eb4b42dd6eb9

Removes the extra check added in https://crrev.com/c/3123735. See recent discussion on the spec here: whatwg/fs#9 (comment) Bug: 1114923, 1399660 Change-Id: I0afd561238ae44dfa055e6fff234e801ee8de616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4090632 Auto-Submit: Austin Sullivan <asully@chromium.org> Reviewed-by: Daseul Lee <dslee@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#1081696}

Spec PR: whatwg/fs#9 Bug: 1114923 Change-Id: Ie52068e0053cf3a1b693e09c5623eb4b42dd6eb9

Spec PR: whatwg/fs#9 Bug: 1114923 Change-Id: Ie52068e0053cf3a1b693e09c5623eb4b42dd6eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4073126 Reviewed-by: Daseul Lee <dslee@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Auto-Submit: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#1081718}

a-sully · 2023-02-02T18:41:38Z

This doesn't seem to have a good delineation between the main thread and the storage thread operations.

The method and the eventual task run in the main thread and can access JS.

What's missing here is an "in parallel" section that runs in some other thread and deals with locks and the file system.

Or am I misunderstanding something?

You're correct, and I've updated this in the latest patchset. It's still not perfect since file locking is still done in parallel on the main thread, but once #95 adds the new framework for file locking we can follow that pattern. I'm happy to do that in a follow-up

a-sully · 2023-02-02T18:49:48Z

Also, #73 (comment) is relevant here, too... we may need to specify what taking locks on a directory looks like (i.e. you can't take the lock if a containing file is locked)

a-sully · 2023-07-17T03:31:26Z

Hi all, I've updated this PR to make use of the various infrastructural changes that have merged recently (primarily #95 and #96). Please take a look at the updated PR. Thanks!

annevk · 2023-11-06T12:06:40Z

+     |accessResult|'s [=file system access result/error name=] and
+     abort these steps.
+
+  1. If |entry| is `null`, [=queue a storage task=] with |global| to [=/reject=]


Nit: https://infra.spec.whatwg.org doesn't use markup for null.

annevk · 2023-11-06T12:07:42Z

+          1. Attempt to remove |child| from the underlying file system.
+             If that throws an exception, [=/reject=] |result| with
+             that exception and abort these steps.


It seems weird that this would happen on the main thread.

annevk · 2023-11-06T12:08:48Z

+
+       Issue(11): Better specify what possible exceptions this could throw.
+
+    1. [=Enqueue the following steps=] to the [=file system queue=]:


Do we really need nested file system queue steps?

… a=testonly Automatic update from web-platform-tests FSA: Allow removing the root of an OPFS Removes the extra check added in https://crrev.com/c/3123735. See recent discussion on the spec here: whatwg/fs#9 (comment) Bug: 1114923, 1399660 Change-Id: I0afd561238ae44dfa055e6fff234e801ee8de616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4090632 Auto-Submit: Austin Sullivan <asully@chromium.org> Reviewed-by: Daseul Lee <dslee@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#1081696} -- wpt-commits: 1a3f3a52208c41caad21964990f0b08a56d0264c wpt-pr: 37440

…m-access to fs, a=testonly Automatic update from web-platform-tests FSA: Migrate remove WPTs from file-system-access to fs Spec PR: whatwg/fs#9 Bug: 1114923 Change-Id: Ie52068e0053cf3a1b693e09c5623eb4b42dd6eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4073126 Reviewed-by: Daseul Lee <dslee@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Auto-Submit: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#1081718} -- wpt-commits: e6c9f0d92dc297b51ad970143ee1680a50ac328f wpt-pr: 37441

annevk · 2026-04-24T16:07:34Z

@fergald this too appears to have shipped in Chromium without the specification being ready with non-tentative tests?!

cc @jesup

a-sully mentioned this pull request Mar 7, 2022

Add FileSystemHandle::remove() method WICG/file-system-access#283

Closed

annevk reviewed Mar 9, 2022

View reviewed changes

Comment thread index.bs Outdated

a-sully mentioned this pull request Apr 28, 2022

Interactions with the BFCache #17

Open

a-sully mentioned this pull request May 24, 2022

Make explicit that FileSystemHandle entries map to paths #30

Closed

a-sully commented May 27, 2022

View reviewed changes

Comment thread index.bs Outdated

a-sully mentioned this pull request Jun 6, 2022

Remove copy and move methods. WICG/file-system-access#50

Merged

a-sully mentioned this pull request Sep 9, 2022

FileSystemHandle.remove() for the File System Access API w3ctag/design-reviews#773

Closed

1 task

rektide mentioned this pull request Oct 2, 2022

initial draft backend for File System specification with Access Handles isomorphic-git/lightning-fs#103

Draft

a-sully closed this Nov 2, 2022

a-sully force-pushed the remove branch from b481550 to 840b322 Compare November 2, 2022 05:37

a-sully reopened this Nov 2, 2022

a-sully mentioned this pull request Nov 2, 2022

Require an exclusive lock in removeEntry() #73

Draft

4 tasks

annevk reviewed Nov 9, 2022

View reviewed changes

Comment thread index.bs Outdated

Comment thread index.bs Outdated

a-sully mentioned this pull request Nov 11, 2022

Consider specifying a parallel queue for operations which acquire locks #74

Closed

This was referenced Dec 7, 2022

Explainer for FileSystemHandle.remove() a-sully/fs#1

Merged

Request for Position: FileSystemHandle Remove Self WebKit/standards-positions#104

Closed

FileSystemHandle Remove Self mozilla/standards-positions#716

Open

annevk reviewed Dec 7, 2022

View reviewed changes

Comment thread index.bs Outdated

Comment thread index.bs Outdated

Comment thread index.bs Outdated

annevk reviewed Dec 8, 2022

View reviewed changes

Comment thread index.bs Outdated

chromium-wpt-export-bot mentioned this pull request Dec 9, 2022

FSA: Allow removing the root of an OPFS web-platform-tests/wpt#37440

Merged

chromium-wpt-export-bot mentioned this pull request Dec 9, 2022

FSA: Migrate remove WPTs from file-system-access to fs web-platform-tests/wpt#37441

Merged

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 9, 2022

FSA: Migrate remove WPTs from file-system-access to fs

60166e6

Spec PR: whatwg/fs#9 Bug: 1114923 Change-Id: Ie52068e0053cf3a1b693e09c5623eb4b42dd6eb9

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 9, 2022

FSA: Migrate remove WPTs from file-system-access to fs

0939aa8

Spec PR: whatwg/fs#9 Bug: 1114923 Change-Id: Ie52068e0053cf3a1b693e09c5623eb4b42dd6eb9

annevk reviewed Feb 14, 2023

View reviewed changes

Comment thread index.bs Outdated

Comment thread index.bs Outdated

Comment thread index.bs Outdated

annevk reviewed Feb 15, 2023

View reviewed changes

Comment thread index.bs Outdated

a-sully mentioned this pull request Feb 15, 2023

Define a parallel queue for all file system operations #95

Merged

4 tasks

hamishwillee mentioned this pull request Mar 6, 2023

Ff111 More OPFS related updaes mdn/browser-compat-data#19056

Merged

tomayac mentioned this pull request Mar 15, 2023

Accessing the parent of FileSystemFileHandle #38

Open

a-sully mentioned this pull request Apr 7, 2023

Specify "origin private file system"-ness on a FileSystemHandle #110

Merged

This was referenced Jun 6, 2023

Clarify behavior of createWritable() when the corresponding file does not exist #125

Open

Add a FileSystemHandle.create() method to create self #126

Open

This was referenced Jun 21, 2023

Support locking of directory entries #137

Open

Require taking a lock to remove an entry #138

Open

a-sully closed this Jun 22, 2023

a-sully force-pushed the remove branch from aa0b505 to abad896 Compare June 22, 2023 01:24

retry specifying remove after whatwg#95

957ffea

a-sully reopened this Jun 22, 2023

release lock after removal

a3797f6

mandaputtra mentioned this pull request Jul 27, 2023

add remove jimmywarting/native-file-system-adapter#14

Closed

This was referenced Oct 7, 2023

FileSystemHandle.remove() should not be marked as non-standard mdn/content#29528

Closed

api.FileSystemHandle.remove - should not be marked as non-standard mdn/browser-compat-data#20916

Closed

annevk reviewed Nov 6, 2023

View reviewed changes

This was referenced May 8, 2024

[zh-cn]: sync translation for FileSystemHandle and all its members mdn/translated-content#20164

Merged

Fix & pretty in FileSystemHandle interface mdn/content#33502

Merged

annevk added the agenda+ To be discussed at a triage meeting label Jun 2, 2026

lukewarlow mentioned this pull request Jun 17, 2026

Extraordinary WHATNOT meeting on 2026-06-17 whatwg/html#12441

Closed

jstenback removed the agenda+ To be discussed at a triage meeting label Jun 25, 2026


		Issue(11): Better specify what possible exceptions this could throw.

		1. [=Enqueue the following steps=] to the [=file system queue=]:

Uh oh!

Conversation

a-sully commented Mar 7, 2022 • edited by pr-preview Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

annevk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

a-sully commented Feb 2, 2023

Uh oh!

a-sully commented Feb 2, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

a-sully commented Jul 17, 2023

Uh oh!

annevk Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

annevk Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

annevk Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

annevk commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

a-sully commented Mar 7, 2022 •

edited by pr-preview Bot

Loading