fix: keep comparison icons beside logged values in routine table (#1264)#1275
Open
gitcommit90 wants to merge 1 commit into
Open
fix: keep comparison icons beside logged values in routine table (#1264)#1275gitcommit90 wants to merge 1 commit into
gitcommit90 wants to merge 1 commit into
Conversation
Wrap logged metrics and comparison icons in a nowrap flex row so icons stay aligned with their values in the table view. Fixes wger-project#1264
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routine table log comparison icons can wrap away from their numeric values when cells are narrow.
Changes
StackwhiteSpace: 'nowrap'Tests
LANG=de_de npx vitest run src/components/Routines/screens/Detail/RoutineDetailsTable.test.tsxFixes #1264