WW-4612 Use the real dropdown height when deciding to flip above - #145
Open
kevinbarfleur wants to merge 1 commit into
Open
WW-4612 Use the real dropdown height when deciding to flip above#145kevinbarfleur wants to merge 1 commit into
kevinbarfleur wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rendered dropdown with one short option measures ~40px, under the 50px sanity guard, so a 300px estimate was used instead and the flip-above branch sent the dropdown to the top of the page. The guard predates the rAF measurement pass that made it obsolete. Known pre-existing edge, improved but not fully covered: the dropdown does not re-sync when bound options arrive after opening.