-
Notifications
You must be signed in to change notification settings - Fork 13
add back count display. allow selected items to be sorted to top #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jaredgibb
wants to merge
25
commits into
weweb-assets:main
Choose a base branch
from
jaredgibb:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
a82779e
update
jaredgibb 7231ecf
commit
jaredgibb b7bdf63
Update wwElement_OptionsList.vue
jaredgibb f49095b
Update wwElement_OptionsList.vue
jaredgibb 57f00d6
Fix comment syntax in ww-config.js
jaredgibb e706865
Add debug logging to OptionsList component
jaredgibb 5d6464c
Refactor search watcher in OptionsList component
jaredgibb 5eaad5f
Remove debug logging from OptionsList, add logs to Select
jaredgibb 57f2e25
Update wwElement_Select.vue
jaredgibb f0cdb18
Add debug watcher for isOpen state changes
jaredgibb c18dd92
Update wwElement_Select.vue
jaredgibb a2bdb67
Add debug watchers for content and initialState
jaredgibb 4ff31b8
Update wwElement_Select.vue
jaredgibb a43816d
Add isSorting flag to manage dropdown sorting state
jaredgibb f9d928b
Add debug logging to Option and Select components
jaredgibb d9b714b
Update wwElement_Option.vue
jaredgibb 795872d
Update wwElement_Option.vue
jaredgibb 9d81074
Add debug logging to options filtering and sorting
jaredgibb f4f611c
Add debug logging to search input handlers
jaredgibb 447a461
Add files via upload
jaredgibb 0bf0117
Merge branch 'main' of https://github.com/jaredgibb/ww-input-select
jaredgibb 4283a5f
Update wwElement_OptionsList.vue
jaredgibb 54ca2bb
Move search filtering logic to Search component
jaredgibb cde1e33
Remove debug console.log statements from components
jaredgibb d18382b
Emit per-item change event (changeOneItem)
jaredgibb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The isSorting flag is being set within a computed property, which violates Vue's reactivity principles. Computed properties should be pure functions without side effects. Setting isSorting.value inside filteredOptions computed will cause it to run during every reactivity cycle, potentially triggering the setTimeout multiple times. This should be moved to a watcher or a method that is called when sorting is actually needed.