feat(select): Add toggle button and remove force open in editor option (WW-3773) - #127
Open
leo91000 wants to merge 7 commits into
Open
feat(select): Add toggle button and remove force open in editor option (WW-3773)#127leo91000 wants to merge 7 commits into
leo91000 wants to merge 7 commits into
Conversation
…that caused issues on dark theme
…that caused issues on dark theme (#124) Co-authored-by: Alexy Carlier <alexy.carlier@gmail.com>
leo91000
force-pushed
the
feature/WW-3773-add-toggle-button
branch
from
May 20, 2025 18:15
5c5e7f5 to
b42207e
Compare
leo91000
force-pushed
the
feature/WW-3773-add-toggle-button
branch
6 times, most recently
from
May 21, 2025 10:52
5685edd to
57e4bc4
Compare
leo91000
force-pushed
the
feature/WW-3773-add-toggle-button
branch
from
May 21, 2025 10:53
57e4bc4 to
affa35c
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new toggle button functionality in the editor panel by replacing the deprecated “Force open in editor” option with a toggle mechanism.
- Replaces 'forceOpenInEditor' with 'toggleSelect' in configuration
- Refactors the state management in wwElement_Select.vue from a computed property to a ref
- Adjusts button actions and labels to support the toggle functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ww-config.js | Updated settings order and property definitions for the new toggle option |
| src/wwElement_Select.vue | Replaced computed property with a ref and added toggle method implementation |
Comments suppressed due to low confidence (1)
ww-config.js:238
- [nitpick] The property 'toggleSelect' is configured with an action 'toggleForceOpenInEditor' and a simple 'Toggle' label, which might be ambiguous. Consider renaming the property or aligning the action name and label to clearly indicate its functionality.
toggleSelect: {
| this.resetLastTriggerComponentAction(); | ||
| this.resetSearch(); | ||
| }, | ||
| toggleForceOpenInEditor() { |
There was a problem hiding this comment.
Switching from a computed property to a ref for 'forceOpenInEditor' necessitates proper reactive handling. Since refs require using '.value' to update their state, ensure that this ref is correctly integrated (for example, by either returning it via setup or declaring it in data) so that toggling works as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary