Skip to content

WW-2029 Render boolean columns as on/off toggle in database action forms #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinbarfleur wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WW-2029 Render boolean columns as on/off toggle in database action forms #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Functions/Database/Delete.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export default {
}
}
for (const field of this.primaryProperties) {
if (!primaryData[field.name]) delete primaryData[field.name];
if (!primaryData[field.name] && primaryData[field.name] !== false) delete primaryData[field.name];
}
this.$emit('update:args', { ...this.args, primaryData });
},
Expand Down
2 changes: 1 addition & 1 deletion src/components/Functions/Database/Insert.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ export default {
}
}
for (const field of this.tablePropertiesFiltered) {
if (!data[field.name]) delete data[field.name];
if (!data[field.name] && data[field.name] !== false) delete data[field.name];
}
}
this.$emit('update:args', { ...this.args, data });
Expand Down
5 changes: 3 additions & 2 deletions src/components/Functions/Database/Update.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ export default {
}
}
for (const field of this.primaryProperties) {
if (!primaryData[field.name]) delete primaryData[field.name];
if (!primaryData[field.name] && primaryData[field.name] !== false) delete primaryData[field.name];
}
this.$emit('update:args', { ...this.args, primaryData });
},
Expand All @@ -228,7 +228,8 @@ export default {
}
}
for (const field of this.tablePropertiesFiltered) {
if (!data[field.name] && data[field.name] !== null) delete data[field.name]; // TODO LOGIC ISSUE HERE
if (!data[field.name] && data[field.name] !== null && data[field.name] !== false)
delete data[field.name]; // TODO LOGIC ISSUE HERE
}
this.$emit('update:args', { ...this.args, data });
},
Expand Down
2 changes: 1 addition & 1 deletion src/components/Functions/Database/Upsert.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ export default {
}
}
for (const field of this.tablePropertiesFiltered) {
if (!data[field.name]) delete data[field.name];
if (!data[field.name] && data[field.name] !== false) delete data[field.name];
}
}
this.$emit('update:args', { ...this.args, data });
Expand Down
1 change: 1 addition & 0 deletions src/wwPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,6 +902,7 @@ export default {
types: {
integer: 'number',
string: 'query',
boolean: 'onoff',
},
};

Expand Down