Repository navigation
Preserve native credentials and atomic settings across upgrades - #1
Merged
Merged
Conversation
added 4 commits
October 22, 2026 12:55
Use current platform providers directly so Linux retains kernel keyutils and its existing keyring-rs entry identity. Keep macOS login Keychain and Windows Credential Manager without changing process-wide store defaults or migrating credentials. Add Linux compatibility and Windows store checks alongside the desktop workspace gate. Advance the desktop workspace to 0.1.2 and coordinate the repository libraries at 0.4.5.
Concurrent Windows writers could replace a file while its previous temporary handle was still open. Close the synced handle before persisting its path and keep the concurrency gate on Windows.
Use the candidate manifest instead of a hardcoded future tag so migration receipts point to the release that was actually checked. Record the HTTP comparison and coordinate the next Atlas library release.
The Windows tempfile persistence implementation does not use modern rename sharing semantics. Use the standard library rename after syncing and closing the temporary file, and verify concurrent writes, retained readers, and cleanup on failure.
wess
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keyring upgrade changed Linux's backend and credential naming, which would hide existing application tokens. Use current platform providers directly and preserve Linux's existing
keyring-rs:<key>@<service>identity. macOS keeps login Keychain identities and Windows keeps Credential Manager identities without changing the process-wide default store.The new Windows gate also exposed concurrent JSON replacement failures. Sync and close temporary files, then use the standard library's Windows-compatible rename path. Regression cases cover concurrent writers, retained readers, and cleanup after failed replacement.
Desktop crates advance to 0.1.4; coordinated repository libraries advance to 0.4.7. The fleet migration planner derives its Inkling tag from the validated candidate instead of a hardcoded future version.
Validation: