Migrate to TypeScript - #3
Open
wescarr wants to merge 1 commit into
Open
Conversation
wescarr
commented
Sep 7, 2022
wescarr
commented
Owner
- Move source to /src from /lib
- Replace deprecated Buffer.slice method with subarray
- Add funding entry
- Better error handling
- Update README to reflect vercel changes
- Move source to /src from /lib - Replace deprecated Buffer.slice method with subarray - Add funding entry - Better error handling - Update README to reflect vercel changes
dudleycarr
reviewed
Oct 7, 2022
| @@ -0,0 +1,27 @@ | |||
| { | |||
| "extends": "@tsconfig/node16/tsconfig.json", | |||
There was a problem hiding this comment.
You might want to consider @sindresorhus/tsconfig instead.
https://github.com/sindresorhus/tsconfig
| "extends": "@tsconfig/node16/tsconfig.json", | ||
| "compilerOptions": { | ||
| "lib": [ | ||
| "es2015", |
There was a problem hiding this comment.
Node LTS is 14 which supports es2020
| "version": "0.1.0", | ||
| "description": "Encrypted environment variables for node done right", | ||
| "engines": { | ||
| "node": ">=12" |
There was a problem hiding this comment.
May as well require Node 14 or later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.