Skip to content

fix: index debug mode, check for updateIndexQuery in dataextensions - #64

Merged
tiller1010 merged 2 commits into
mainfrom
hotfix/3.1.2/debug-mode-and-extensions-fix
Jun 22, 2026
Merged

fix: index debug mode, check for updateIndexQuery in dataextensions#64
tiller1010 merged 2 commits into
mainfrom
hotfix/3.1.2/debug-mode-and-extensions-fix

Conversation

@tiller1010

@tiller1010 tiller1010 commented Jun 19, 2026

Copy link
Copy Markdown
Member

https://werkbotstudios.teamwork.com/app/tasks/39646343

Summary

  • index debug mode
  • check for updateIndexQuery in dataextensions

Testing Steps

  • (optional) test with reed searchable files, confirm they can be published
    • (optional) extend the Image class with its own index query (using updateIndexQuery), confirm this works as expected
  • mess up an index query, add ?debug to the search index task, confirm your query shows with the error

Git Flow

  • DO NOT delete "release/*" or "hotfix/*" branches after merging a PR. These are used to publish the next release, and they are deleted automatically.
  • "Squash and merge" is good on "feature/*" into "develop"
  • "Create a merge commit" is good on "release/*" or "hotfix/*" into "main"

@tiller1010
tiller1010 requested a review from aletail June 19, 2026 16:07

@aletail aletail left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

Comment thread src/Tasks/SearchIndex.php Outdated

if ($debugMode) {
// Ensure this query is valid by running it before adding it to the indexer
DB::query($classQuery);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could try and catch the exception - though I guess that depends if you want the index to continue and just notify the user or if you want it to stop immediately

@tiller1010
tiller1010 merged commit 0672625 into main Jun 22, 2026
2 checks passed
@github-actions
github-actions Bot deleted the hotfix/3.1.2/debug-mode-and-extensions-fix branch June 22, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants