feat: added extension point to getIndexQuery - #58
Merged
Conversation
aletail
requested changes
Jun 4, 2026
aletail
left a comment
aletail
left a comment
Member
There was a problem hiding this comment.
Looks good - just see my one comment, I am probably overlooking something
| { | ||
| return false; | ||
| $query = ''; | ||
| $this->owner->extend('updateIndexQuery', $query); |
Member
There was a problem hiding this comment.
Not following why we have an extend here, if we overwrite this function (which is the intended route anyway right?) then why would we need the extend?
Member
Author
There was a problem hiding this comment.
This allows a data extension to define the index query. This basically lets us add search functionality to any dataobject in the vendor directory.
Product::add_extension(SearchableExtension::class);
Product::add_extension(ProductExtension::class); // Defines the index queryAdding getIndexQuery to a data extension, after adding the searchable extension, would not work because it is defined in the searchable extension.
aletail
approved these changes
Jun 4, 2026
| { | ||
| return false; | ||
| $query = ''; | ||
| $this->owner->extend('updateIndexQuery', $query); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://werkbotstudios.teamwork.com/app/tasks/39565673
Summary
added extension point to getIndexQuery. Allows index query to be added by dataextensions
Testing Steps
Issues/Concerns
getIndexQuery(like blog Articles in the case of flexcut), this won't be used. Feel free to double check this by extending articles.Git Flow