Repository navigation
Share the save validators with the solve log - #58
Merged
Merged
Conversation
solves.ts had its own copies of save.ts's object and duration checks. It now imports them, so the rules for saved data live in one place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SGfak3CRUUVwG8x6w8D3gr
|
Visit the preview URL for this PR (updated for commit e61fdfa): https://stumped-game--pr58-claude-project-threa-orjk7ga9.web.app (expires Sat, 07 Nov 2026 14:56:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dfc2bf844eeac82ebd1846d84aacfdcd42e42a2f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Barry · project thread
Fixes item 9 from the Ponytail repo audit.
src/solves.tsdefined its own copies of theobjectanddurationchecks fromsrc/save.ts. Nowsave.tsexports them as documented functions, as AGENTS.md requires for exported helpers, andsolves.tsimports them. If the rules for saved data change, there is one place to change them.countstays insolves.ts, sincesave.tshas no matching check (itsintegertakes a range). The diff is +5 lines net, because the exported helpers need JSDoc and thefunctionform. The gain is one definition, not fewer lines.No behavior change and no version bump.
pnpm run checkpasses (324 tests, including the save and solve log validation tests).Generated by Claude Code