Repository navigation
Drop Firebase's catch-all rewrite - #57
Merged
Merged
Conversation
The game has no routes (seed codes use ?code=), so the rewrite only served index.html with status 200 for files that do not exist, such as an old build's script. Missing files now get a plain 404. firebase.json changes now trigger a deploy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SGfak3CRUUVwG8x6w8D3gr
|
Visit the preview URL for this PR (updated for commit 75cbb78): https://stumped-game--pr57-claude-project-threa-961oaaac.web.app (expires Sat, 07 Nov 2026 14:54:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dfc2bf844eeac82ebd1846d84aacfdcd42e42a2f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Barry · project thread
Fixes item 8 from the Ponytail repo audit.
firebase.jsonrewrote every unknown path to/index.html. The game has no routes: seed codes use?code=, the manifest'sstart_urlis., and the onlyhistorycall clears the query. So the rewrite only mattered for files that don't exist, such as a page on an old build asking for a script the deploy removed. Those requests got HTML with status 200, which shows up as a confusing script error. They now get Firebase's plain 404.firebase.json: removesrewrites.firebase-hosting-merge.yml: addsfirebase.jsonto the deploy paths, so a hosting config change deploys on its own.AGENTS.md: listsfirebase.jsonamong the paths that deploy.No version bump, since players see no change. The Firebase preview on this PR uses the new config, so
/and/?code=…can be checked there, and a made-up path should 404.Generated by Claude Code