Repository navigation
Fix audit items 7 and 10, build deploys with solve data (v0.11.3) - #56
Merged
Merged
Conversation
AGENTS.md pointed to a docs/summary.md that does not exist, and comments in scripts/offline.ts and src/index.ts described the bake-off builds as sharing the app's origin, which was only true on GitHub Pages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SGfak3CRUUVwG8x6w8D3gr
|
Visit the preview URL for this PR (updated for commit 530c7d0): https://stumped-game--pr56-claude-project-threa-w2lo7xxp.web.app (expires Sat, 07 Nov 2026 14:44:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dfc2bf844eeac82ebd1846d84aacfdcd42e42a2f |
Share copied the link with no failure handler, so a refused clipboard left the button doing nothing. It now flashes "Could not copy", like Copy solve data. The deploy and preview workflows build with VITE_COLLECT_SOLVE_DATA=true so the live game keeps the solve log. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SGfak3CRUUVwG8x6w8D3gr
weevilgenius
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Barry · project thread
Fixes items 7 and 10 from the Ponytail repo audit, and builds the deployed game with solve data collection on. This branch is the one this thread works on, so item 7 joined the item 10 PR rather than starting a new branch.
Item 7: Share fails silently
On browsers without a share sheet, Share copied the link with no failure handler. A missing or refused clipboard left the button doing nothing, and the rejection went unhandled. It now flashes "Could not copy" for 1.5 seconds, matching how Copy solve data reports a failure (
src/index.ts).Solve data in deploys
Both Firebase workflows set
VITE_COLLECT_SOLVE_DATA: 'true'on thepnpm run buildstep only, so the live site and previews keep the solve log and the Copy solve data button. Unit tests still run with the flag unset; they stub it where they need it.Item 10: stale docs and comments (comments only)
AGENTS.md: drops the pointer todocs/summary.md, which doesn't exist.scripts/offline.ts: two JSDoc comments no longer say the comparison apps share the worker scope. The generatedsw.jsis unchanged.src/index.ts: theSTORAGE_PREFIXcomment explains why the prefix is kept.v0.11.3 with changelog lines for the Share fix and the solve record returning.
Checks
pnpm run checkpasses (324 tests).VITE_COLLECT_SOLVE_DATA=true pnpm run buildsucceeds, and the bundle includes Copy solve data.🤖 Generated with Claude Code
https://claude.ai/code/session_01SGfak3CRUUVwG8x6w8D3gr