chore: add @see test annotations to satisfy rector#18
Merged
Conversation
AddSeeTestAnnotationRector (part of the configured rector set) requires model classes with corresponding tests to carry an @see annotation pointing at their test class. This restores a green `make rector-dry`. Verified with `make rector-dry` (Rector is done!) and `make analyse` (no errors).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
@seeclass-level annotations toMenuandMenuItempointing at their respective test classes:Menu→@see \WeDevelop\Menustructure\Tests\Model\MenuTestMenuItem→@see \WeDevelop\Menustructure\Tests\Model\MenuItemTestWhy
make rector-drywas failing on6viaAddSeeTestAnnotationRector(part of the configured rector preset), which requires model classes that have a corresponding test to carry an@seeannotation linking to it. This is the canonical output ofmake rector— it's a pre-existing failure unrelated to any feature change, surfaced by a rector version drift since the last green run.This restores a green
static-analysisCI job.Verification
make rector-dry→ Rector is done! (no changes)make analyse(silverstan, levelmax) → No errors