chore: drop redundant @config annotations#17
Merged
Conversation
Silverstan natively recognises SilverStripe config properties as always read and written, so the /** @config */ docblocks no longer suppress any analysis. The properties already carry native scalar/array types, so type coverage is unaffected. Verified with `make analyse` (silverstan level max): no errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes all
/** @config */docblock annotations fromMenuandMenuItem(14 in total).Why
The dev QA chain now uses
cambis/silverstan, which natively recognises SilverStripe configuration properties as always read and written. The sole purpose of/** @config */was to stop static analysis flagging theseprivate staticconfig statics as unused/write-only — silverstan does this automatically, so the annotations are now pure noise.The properties already carry native scalar/array types (
string,array,bool), so the@configdocblocks contributed nothing to type coverage; removing them leavesproperty_type: 100intact.Verification
make analyse(silverstan, levelmax, 100% type coverage) → No errorsNote (out of scope)
make rector-dryreports a finding fromAddSeeTestAnnotationRector(wants@see ...Testclass annotations). This is pre-existing on6— it reproduces on a clean checkout without these changes — and is unrelated to the@configcleanup. Left for a separate PR.