feature: simplify user creation (https://webitel.atlassian.net/browse/WTEL-9735)[WTEL-9735]#1323
Open
RomanZaritskyi wants to merge 7 commits into
Open
feature: simplify user creation (https://webitel.atlassian.net/browse/WTEL-9735)[WTEL-9735]#1323RomanZaritskyi wants to merge 7 commits into
RomanZaritskyi wants to merge 7 commits into
Conversation
added 5 commits
June 18, 2026 02:25
dlohvinov
reviewed
Jun 23, 2026
| chatName: 'Chat display name', | ||
| temporaryPassword: 'Temporary password', | ||
| extensionsHelperText: 'Extension must contain only digits', | ||
| // WTEL-9735 Підзадача 6 |
Contributor
There was a problem hiding this comment.
коментарі би англом пасувало би писати)
Contributor
Author
There was a problem hiding this comment.
та його видалити треба..))
|
|
||
| import { useUserAccessControl } from '../../../../../app/composables/useUserAccessControl'; | ||
| import openedTabComponentMixin from '../../../../../app/mixins/objectPagesMixins/openedObjectTabMixin/openedTabComponentMixin'; | ||
| import ContactsAPI from '../api/contacts.js'; |
Contributor
There was a problem hiding this comment.
по можливості краще імпортувати одразу з @webitel/api-services/api
| lang="scss" | ||
| scoped | ||
| > | ||
| @use '@webitel/ui-sdk/src/css/main' as *; |
Comment on lines
+183
to
+185
| import RolesAPI from '../../../../permissions/modules/roles/api/roles'; | ||
| import DevicesAPI from '../../devices/api/devices'; | ||
| import LicenseAPI from '../../license/api/license'; |
Contributor
There was a problem hiding this comment.
якщо можна імпортувати з @webitel/api-services/api, то було би круто)
але якщо ні то ні
Contributor
Author
There was a problem hiding this comment.
з того що бачу то поки не можна
Contributor
Author
There was a problem hiding this comment.
Ці апішки унікальні для адмінки. Пропоную їх поки не виности в api-services. Але якщо треба і на це є причини то можу винести.
Я просто думаю що яещо вони ніде не потрібні, то їх винесення в api-services — це + до складності розробки в подальному.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.