feat(internal-plugin-llm): llmrefactor - renamed disconnectLLM in channel#5083
feat(internal-plugin-llm): llmrefactor - renamed disconnectLLM in channel#5083shnaaz wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a70cb7ac2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| this.ownerMeetingId = undefined; | ||
| }); | ||
| }; | ||
| public async disconnect(options?: {code: number; reason: string}): Promise<void> { |
There was a problem hiding this comment.
Preserve the channel disconnectLLM alias
Because this class is still exported as the package default, any direct LLMChannel consumer that still calls the pre-existing disconnectLLM() method will now get a runtime TypeError; the commit only updates LLMPlugin internals, so this is a breaking change for direct channel users. Please keep a small disconnectLLM() wrapper that delegates to the new disconnect() while allowing disconnect() to clear LLM-specific state.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
this is fine, we can break the APIs for LLM
COMPLETES #< INSERT LINK TO ISSUE >
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-827598
This pull request addresses
< DESCRIBE THE CONTEXT OF THE ISSUE >
by making the following changes
< DESCRIBE YOUR CHANGES >
renamed disconnectLLM in llm.ts to disconnect
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.