[BUGFIX] DPL-158: Fix CKEditor modal tabs for TYPO3 v14#56
Merged
Conversation
TYPO3 v14 replaced the Bootstrap tab handling with the dedicated `@typo3/backend/tab.js` module. Its canonical markup uses a `data-typo3-tab` attribute on the tab button instead of the former `data-bs-toggle="tab"` / `data-bs-target` combination. The DeepL Write CKEditor modal still used the Bootstrap markup, so switching between the `Style` and `Tone` tabs no longer worked in TYPO3 v14. Adopt the v14 tab markup in the version specific `Resources/Private/Core14/Backend/Templates/CkEditor/Edit.html` template, matching the core `Tabs.fluid.html` partial. The TYPO3 v13 template keeps the Bootstrap markup.
Documentation renderingYou can find files attached to the below linked Workflow Run URL (Logs). Please note that files only stay for around 5 days!
|
calien666
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Switching between the
StyleandTonetabs in the DeepL WriteCKEditor modal no longer works in TYPO3 v14.
Cause
TYPO3 v14 replaced the Bootstrap tab handling with the dedicated
@typo3/backend/tab.jsmodule (the former@typo3/backend/tabs.jsis now only a deprecation shim). Its canonical markup — see the core
Partials/ModuleTemplate/Tabs.fluid.html— drives the tab buttonthrough a
data-typo3-tab="#<panel-id>"attribute instead of theformer Bootstrap
data-bs-toggle="tab"/data-bs-targetpair.The modal template still used the Bootstrap markup, and since
modal.jsdoes not initialize tabs on its own, the tabs stayedinert.
Fix
Adopt the v14 tab markup in the version specific
Resources/Private/Core14/Backend/Templates/CkEditor/Edit.html:data-bs-toggle="tab"+data-bs-target="#id"→data-typo3-tab="#id"aria-controls="#id"→aria-controls="id"The TYPO3 v13 template keeps the Bootstrap markup.
Verification
Tab switching confirmed working in a TYPO3 v14 backend installation.
Screenshot TYPO3 v14 instance