[BUGFIX] DPL-158: Use static DeepL Write localization icon#55
Merged
Conversation
The `ApplyLocalizationModesEventListener` selected a TYPO3 core version aware icon identifier (`actions-localize-deepl-13` for v13, `actions-localize-deepl` otherwise). Both identifiers no longer exist and the localization mode was rendered without its icon. Use the static `actions-localize-deepl-write` icon registered in `Configuration/Icons.php` instead, matching the TYPO3 v14 `DeeplWriteLocalizationHandler`. The now obsolete `Typo3Version` lookup is removed.
Documentation renderingYou can find files attached to the below linked Workflow Run URL (Logs). Please note that files only stay for around 5 days!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ApplyLocalizationModesEventListenerselected a TYPO3 core versionaware icon identifier for the
deeplwritelocalization mode:Both identifiers no longer exist, so the localization mode was
rendered without its icon.
Fix
Use the static
actions-localize-deepl-writeicon registered inConfiguration/Icons.php, matching the TYPO3 v14DeeplWriteLocalizationHandlerwhich already returns that identifier.The now obsolete
Typo3Versionlookup and import are removed.A codebase-wide check confirmed this was the only remaining
core-version-aware icon usage.
Verification
Build/Scripts/runTests.sh -s cgl -n→ SUCCESS