[BUGFIX] DPL-173: Let DeeplBaseScgIconProvider return inline svg correctly#80
Merged
Merged
Conversation
Documentation renderingYou can find files attached to the below linked Workflow Run URL (Logs). Please note that files only stay for around 5 days!
|
sbuerk
force-pushed
the
dpl-173-modeaware-icon-rendering-issue
branch
from
f3bc3d4 to
bd80377
Compare
…rrectly Simply generating a `svg use` markup for inline svg icons worked for chrome based browser but failed for `Firefox`. TYPO3 v14 changed the implementation mainly due to the introduction of the system resource api and `AbstractSvgIconProvider::getInlineSvg()` seems to work pretty fine if used in the custom icon provider. However, that does not solve the problem for TYPO3 v13 instances. To get mode aware svg icons working for TYPO3 v13 and v14 our custom implementation uses `getInlinveSvg()` for both with the core-version aware workaround to properly resolve to a full absolute path to the `svg` file to ensure the content can be found and inlined. > [!IMPORTANT] > Due to the strict backend icon caching that possible requires > a manual refresh (clear) of the browser local storage cache, > otherwise consuming extension are required to register icons > under a new name to ensure that it got resolved completly new.
sbuerk
force-pushed
the
dpl-173-modeaware-icon-rendering-issue
branch
from
bd80377 to
83a080b
Compare
sbuerk
changed the title
DeeplBaseScgIconProvider return inline svg correctlyDeeplBaseScgIconProvider return inline svg correctly
calien666
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply generating a
svg usemarkup for inline svg icons worked forchrome based browser but failed for
Firefox.TYPO3 v14 changed the implementation mainly due to the introduction of
the system resource api and
AbstractSvgIconProvider::getInlineSvg()seems to work pretty fine if used in the custom icon provider. However,
that does not solve the problem for TYPO3 v13 instances.
To get mode aware svg icons working for TYPO3 v13 and v14 our custom
implementation uses
getInlinveSvg()for both with the core-versionaware workaround to properly resolve to a full absolute path to the
svgfile to ensure the content can be found and inlined.Important
Due to the strict backend icon caching that possible requires
a manual refresh (clear) of the browser local storage cache,
otherwise consuming extension are required to register icons
under a new name to ensure that it got resolved completly new.
Firefox v13 - ensured cleared local icon storage
Firefox v14 - ensured cleared local icon storage