ci: run the whole release sequence in a single job - #700
Merged
Conversation
The release command runs `git checkout <release branch>`, which is what makes that branch available locally; the four commands that follow need it. Running each of them in its own job gave every one a fresh checkout of the default branch, so any release cut from an older branch failed the merge-up with "fatal: not a valid object name". Sharing one job also drops the `if: always()` chain: a failed step no longer lets the next ones advance the release cycle for a release that never happened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as bd025c8, which landed on
4.2.xonly. This branch carries it to4.3.x.The
releasecommand runsgit checkout <release branch>, which is what makes that branch available locally;create-merge-up-pull-requestthen runsgit branch <tmp> <release branch>and needs it. With one job per command, each got a fresh checkout of the default branch, so every release cut from an older branch failed withfatal: not a valid object name.4.3.xis the default branch, so this is the copy GitHub actually runs formilestone: closedevents — the fix is inert until it lands here.Pinned action versions and per-command tokens are unchanged.