Add jws-diag instances command: detect all running Tomcat instances via /proc - #21
Merged
Merged
Conversation
Collaborator
Author
Member
|
Test plan claims "unreadable entries" tested but no such test exists |
dsoumis
force-pushed
the
feat/multi-instance
branch
from
August 14, 2026 21:11
8fa42bc to
df5a606
Compare
dsoumis
force-pushed
the
feat/multi-instance
branch
from
August 14, 2026 21:16
df5a606 to
28f918f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InstanceScannerthat scans all/proc/*/cmdlineentries for the Bootstrap class and returns every running Tomcat process (sorted by PID ascending), unlike the existingProcessDetectorwhich returns only the firstTomcatInstancevalue object (PID, catalinaHome, catalinaBase)instancessub-command with--format human|jsonoutput{pid, catalinaHome, catalinaBase}objectsDesign decisions
InstanceScannerispublicwith a package-accessible constructor accepting aPath procRootfor deterministic unit tests (no live/procneeded)-Dcatalina.baseis absent (matches Tomcat startup behaviour)Test plan
InstanceScannerTestsynthetic/proctree: zero instances, one instance, multiple instances, unreadable entries, missing flagsInstancesHumanFormatterTestgolden snapshot for 0 / 1 / N instancesInstancesJsonFormatterTestgolden snapshot for 0 / 1 / N instancesmvn verifypasses (394 tests, 0 failures)