fs: add tests for null WriteParams members throwing TypeError#58156
Open
usamanadeemdeveloper wants to merge 1 commit into
Open
fs: add tests for null WriteParams members throwing TypeError#58156usamanadeemdeveloper wants to merge 1 commit into
usamanadeemdeveloper wants to merge 1 commit into
Conversation
`size`, `position`, and `data` in `WriteParams` are being made non-nullable (whatwg/fs#181). Add tests to verify that passing null for each of these members throws a TypeError at the WebIDL boundary. A test for `data: null` already existed; this adds the missing cases for `position: null` and `size: null`.
5 tasks
Author
|
Hi @mkruisselbrink, just wanted to check in any chance you'll get to review this? It's the companion test PR for whatwg/fs#182. Everything looks good on my end, but please let me know if there's anything blocking it from your side? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
size,position, anddatainWriteParamsare being made non-nullable (whatwg/fs#181). Add tests to verify that passing null for each of these members throws a TypeError at the WebIDL boundary.A test for
data: nullalready existed; this adds the missing casesfor
position: nullandsize: null.