Branch k#16
Open
namkhanh-le wants to merge 7 commits into
Open
Conversation
Feat/domain implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes
createBalanceAmount was checking amount < 0 before checking isFinite, meaning NaN and -Infinity could slip through in the wrong order. Fixed.
createAccountHoldername had a typo in the function name (lowercase n) — fixed to createAccountHolderName.
Code quality
Extracted two reusable helper functions (assertFinitePositive, assertMinimumBalance) to eliminate repeated validation logic across withdraw, transfer, and createAccount.
Added validation for deposit and transfer amount values (they were never checked for being negative or infinite).
Consistent punctuation and clearer error messages throughout.
Cleaner formatting with section comments to separate helpers, factories, and operations.