Skip to content

feature/atomic structure#3

Open
shsavage1993 wants to merge 10 commits into
developfrom
feature/atomic-structure
Open

feature/atomic structure#3
shsavage1993 wants to merge 10 commits into
developfrom
feature/atomic-structure

Conversation

@shsavage1993

Copy link
Copy Markdown

No description provided.

Comment thread jest.config.ts
export default {
testEnvironment: "jsdom",
moduleNameMapper: {
"^@/(.*)$": "<rootDir>/src/$1",

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added for module aliasing

Comment thread jest.setup.ts

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jest mocks for splide

expect(handleClick).toHaveBeenCalledTimes(2);
});

// it("should not display if isHidden property is set to true", () => {

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not able to test anything related to css (need to include transformers in Jest)

Comment thread tsconfig.json
"moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
// "baseUrl": "./", /* Base directory to resolve non-absolute module names. */
// "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
"paths": {

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For module aliasing

Comment thread tsconfig.json
"typeRoots": [
"./node_modules/@types"
], /* List of folders to include type definitions from. */
// "typeRoots": [

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this as it was resulting in an error with jest

Comment thread src/styles/globals.scss
@import 'vars';
@import 'mixins';
@import 'typography';
@import "vars";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@import is deprecated and will be removed in future versions of Sass, please use @use instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants