Allow for proposed new parsing of array[end]#7
Merged
Conversation
wdebeaum
force-pushed
the
fix-end-parsing
branch
from
March 17, 2025 23:33
ce7162d to
9c1b181
Compare
Contributor
Author
|
Thanks @wdebeaum! Whenever you have time, could you put this change into a release? This would make it easier for me to check that packages depending on PEG work OK with the parsing change. |
Owner
|
I was going to wait until JuliaLang/julia#57368 got merged, but OK, if it helps you out: v1.0.3 |
|
@wdebeaum Did you mean to register that release? |
wdebeaum
added a commit
that referenced
this pull request
Mar 29, 2025
...so that Registrator can see it (oops). v1.0.3 was done via git tag and github release first, which is the wrong order. Skipping that version here to avoid having to move the git tag etc. See issue #7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix JuliaLang/julia#57269, a small-but-breaking julia AST change is needed (PR + discussion JuliaLang/julia#57368).
PEG.jl is currently incompatible with the new parsing, which causes a handful of packages to fail while evaluating the parsing change. This PR makes PEG.jl work with the new parsing, and shouldn't change its compatibility with any existing version of julia.
Note that the parsing change isn't merged yet, but it's planned to be. If the change is cancelled, I'll come back and remove the code I've added here.