Repository navigation
feat(signature-verification): Verifies the Teamtailor webhook signature (v2) in Ingress - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ingress now accepts only webhooks with a valid
TT-Signaturev2 header and answers 401 to everything else,before the body is parsed or stored. This closes the known limitation "Ingress accepts unsigned webhooks".
Changes
Infrastructure.Teamtailor(TeamtailorSignatureFilter), attached to thewebhook route with
RequireTeamtailorSignature(). The webhook parser is unchanged: it only parses.The filter reads the raw body with
EnableBuffering()and rewinds it, because the endpoint hashes the same bytes into theEventId.Infrastructure.TeamtailorgainsRequireTeamtailorSignature, so the project now referencesthe ASP.NET Core shared framework (
docs/architecture.mdupdated). Two package references that the frameworkalready provides were removed (NU1510).
Teamtailor:WebhookSignatureKey(fake value inappsettings.Development.json, real one inuser-secrets or the environment) and
Teamtailor:WebhookSignatureTolerance(00:05:00), both validated on start.Teamtailor/WebhookSignature), never sharedwith
src/, so a misreading of the docs cannot make both sides agree. Integration tests that call Ingressdirectly sign with the same class.
docs/acceptance-scenarios.md): a webhook signed with another key gets 401 and leaves no outbox row.The scenario intro now allows a rule in
.claude/rules/as what a scenario illustrates.