Repository navigation
chore: Polishes docs, local run and CI before the signature step - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final polish of the MVP: the README describes what was built,
run-local.shapplies the EF migrations, the docsdescribe only what exists, and CI checks formatting.
Docs
testing (acceptance scenarios, unit tests, CI, offline prompt evaluation), ADR table, known limitations,
one-time setup for a manual run (
deploy/.env, connection string in user secrets), license note.The "work in progress" status is gone.
acceptance scenarios (I3, I4) and ADRs 003 and 004 no longer describe it. They come back together with the
implementation. Teamtailor's own signature format stays documented in
.claude/rules/teamtailor.md.architecture.md:dotnet-tools.jsonadded to the repository layout; the public surface ofInfrastructure.Teamtailorlists only what exists (IWebhookParserand its result).CLAUDE.md: the EF migration command points to the tool manifest instead of "verify once the firstDbContextexists".TODO: confirm this rationale.; the rationale itself is unchanged.diagrams.md,e2e.http: span names as exported, link to the screenshot, setup steps viarun-local.sh.Local run
deploy/run-local.shrestoresdotnet-efand applies pending migrations for all threeDbContexts afterthe build and before the hosts start, so neither the relay nor a worker meets a missing table.
CI and formatting
.editorconfig: spaces, indent 4 (2 for project, JSON and YAML files), final newline, no trailing whitespace.end_of_lineis unset because the index holds LF and Windows checkouts get CRLF throughcore.autocrlf.charsetis unset becausedotnet efwrites migrations with a BOM.dotnet format --verify-no-changes, which fails the PR on unformatted code.is SqlException { Number: ... }patterns reformatted, the only existingdotnet formatfindings.Forward-looking TODO and doc comments about the signature removed. No behaviour change.