feat: image cacheKey#140
Open
jbrodriguez-bytelion wants to merge 2 commits into
Open
Conversation
Add an option to use a cache key that is different from the image URI. This is useful for example if the image URI contains a parameter that changes, but the image doesn't vary as a result, such as an authentication token. If the cache key is not present, the image URI will be used as the cache key.
Create a single promise to handle the downloading of a cache entry. Otherwise, multiple calls to get the path of a new cache entry will result in multiple downloads, until one of the downloads is successful. If the download is unsuccesful, unset the promise so that the next request will result in a new attempt to download the image.
|
Hey @wcandillon! There is any chance of getting this merged soon? I need a key because my image uri is not static :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we need this feature, I've rebased the original PR for upstream inclusion