Skip to content

Add upcoming terms of use page#1130

Open
rosalieper wants to merge 22 commits into
mainfrom
T420575
Open

Add upcoming terms of use page#1130
rosalieper wants to merge 22 commits into
mainfrom
T420575

Conversation

@rosalieper

@rosalieper rosalieper commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Bug: T420575

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Deployment previews on netlify for branch refs/pull/1130/merge will be at the following locations (when build is done):

Comment thread src/components/Pages/TermsOfUse/Upcoming.vue Outdated
Comment thread src/components/Pages/TermsOfUseUpcoming.vue Outdated
Comment thread src/components/Pages/TermsOfUse/Upcoming.vue Outdated
@deer-wmde deer-wmde mentioned this pull request Jun 2, 2026
@deer-wmde

Copy link
Copy Markdown
Contributor

The footnote links I added need the change from here to work #1131

@rosalieper rosalieper marked this pull request as ready for review June 5, 2026 08:53
@rosalieper

Copy link
Copy Markdown
Contributor Author

The browser test failure is unrelated to this change.

@rosalieper rosalieper changed the title WIP: Add upcoming terms of use page Add upcoming terms of use page Jun 5, 2026
Comment thread src/components/Pages/TermsOfUse/Upcoming.vue Outdated
Comment thread src/components/Pages/TermsOfUse/Upcoming.vue Outdated

@dati18 dati18 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is my review, please check :)

Comment thread src/components/Pages/TermsOfUse/Upcoming.vue Outdated
Comment thread src/components/Pages/TermsOfUse/Upcoming.vue
Comment thread src/components/Pages/TermsOfUse/Upcoming.vue
Comment thread src/components/Pages/TermsOfUse/Upcoming.vue Outdated
Comment thread src/components/Pages/TermsOfUse/Upcoming.vue Outdated
Comment thread src/components/Pages/TermsOfUse/Upcoming.vue
Comment thread src/components/Pages/TermsOfUse/Upcoming.vue Outdated
Comment thread src/components/Pages/TermsOfUse/Upcoming.vue Outdated
Comment thread src/components/Pages/TermsOfUse/Upcoming.vue Outdated
Comment thread src/components/Pages/TermsOfUse/Upcoming.vue Outdated
deer-wmde added a commit that referenced this pull request Jun 11, 2026
This change came up with #1128 and I
put it in its own PR because #1130
also needs this

This fix addresses several things:
1. scroll to the top of the page after following an internal page link
2. making on-page anchor-links (#) work specified with vue router-link

https://phabricator.wikimedia.org/T408254
https://phabricator.wikimedia.org/T420575
@deer-wmde

Copy link
Copy Markdown
Contributor

I updated the branch since #1131 got merged and to re-trigger test CI

@deer-wmde

Copy link
Copy Markdown
Contributor

looks ready from my side! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants